Conversation
- Add image compression when clipboard images exceed 4MB (API limit is 5MB) - Use ImageMagick for progressive compression (quality 85→30, resize 100%→25%) - Convert oversized PNGs to optimized JPEGs - Graceful fallback if ImageMagick unavailable fix(provider): allow instructions param for Codex API - Add "instructions" to OpenAI supported params whitelist - Fixes "Instructions are required" error with gpt-5.2-codex Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Remove commented-out testing delay code that was never used.
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d9194ca73a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Exit codes: 0 = matches found, 1 = no matches, 2 = errors (but may still have matches) | ||
| // With --no-messages, we suppress error output but still get exit code 2 for broken symlinks etc. | ||
| // Only fail if exit code is 2 AND no output was produced | ||
| if (exitCode === 1 || (exitCode === 2 && !output.trim())) { |
There was a problem hiding this comment.
With the new early return on exitCode === 2 && !output.trim(), ripgrep syntax errors now get reported as “No files found.” rg --help explicitly states that --no-messages suppresses file open/read errors but “Error messages related to the syntax of the pattern are still shown,” so a malformed pattern (e.g., an unmatched [) will still emit stderr while stdout is empty. The current branch ignores errorOutput and turns that into a zero-match result, which hides real query errors and can mislead users into thinking nothing matched when the pattern was invalid.
Useful? React with 👍 / 👎.
2 participants
Remove commented-out testing delay code in content-code.tsx that was never used.